Add differenced AR models #134
Merged
+285
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
force-pushed
the
diff-latent-model
branch
from
4125622 to
b559fcd
Compare
|
Looking at this... I'm loving the self-referential definition of AR differencing function. That is neat. |
|
If it works.. I am seeing it work and then not work in quite a strange way. Getting errors about thread safety. |
|
@SamuelBrand1 FYI 4a4f85e this branch was pulled off of #issue53 and so should have been rebased or merged from that PR - that is why it now has so merge many issues. |
|
Why not just kill off branch |
seabbs
force-pushed
the
diff-latent-model
branch
from
9d0daff to
b588826
Compare
…ith having defaults
seabbs
force-pushed
the
diff-latent-model
branch
from
d64bb4a to
bab886e
Compare
SamuelBrand1
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title. This PR extends #128 to include differencing for any latent model. It is joint work from @SamuelBrand1 and me but I think @SamuelBrand1 is still objective enough to review.
Since we discussed this I have:
AR()implementationI think that covered everything we discussed.